Add local nginx dev env #3752
Merged
Add local nginx dev env #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
==========================================
- Coverage 86.89% 86.86% -0.04%
==========================================
Files 128 128
Lines 16201 16201
Branches 62 62
==========================================
- Hits 14078 14073 -5
- Misses 1951 1954 +3
- Partials 172 174 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a local development environment for testing nginx configurations in Kubernetes. It provides a simple setup with nginx proxying to an echo server backend for easier local development and testing.
- Creates kubernetes deployment manifests for nginx proxy and echo server
- Adds nginx configuration with health check and proxy setup
- Provides a Makefile with convenient commands for deployment, testing, and cleanup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dev/nginx/nginx.yaml | Kubernetes manifests for nginx proxy deployment, echo server deployment, and echo service |
| dev/nginx/nginx.conf | Basic nginx configuration with upstream backend and proxy rules |
| dev/nginx/README.md | Documentation explaining how to use the development environment |
| dev/nginx/Makefile | Automation commands for deploying, testing, and managing the development setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sarthyparty
force-pushed
the
feature/nginx-env
branch
from
45de805 to
018c2be
Compare
salonichf5
reviewed
Aug 18, 2025
salonichf5
reviewed
Aug 18, 2025
salonichf5
reviewed
Aug 18, 2025
salonichf5
reviewed
Aug 20, 2025
salonichf5
reviewed
Aug 20, 2025
salonichf5
reviewed
Aug 20, 2025
salonichf5
reviewed
Aug 20, 2025
salonichf5
reviewed
Aug 20, 2025
sjberman
reviewed
Aug 20, 2025
sarthyparty
force-pushed
the
feature/nginx-env
branch
from
63c4347 to
3c22d2a
Compare
sarthyparty
force-pushed
the
feature/nginx-env
branch
from
3c22d2a to
8cc5e2c
Compare
sjberman
approved these changes
Aug 20, 2025
salonichf5
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Developers found it difficult and annoying to test local nginx configuration..
Solution: I created a solution that creates a simple nginx pod with conf in a ConfigMap and a Makefile for easy use.
Testing: Manually tested
Closes #1502
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.