KEMBAR78
Use GITHUB_TOKEN for opening automated PRs by ciarams87 · Pull Request #3783 · nginx/nginx-gateway-fabric · GitHub
Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: NGINX_PAT no longer works for opening PRs

Solution: Use GITHUB_TOKEN with pull request permissions instead

Testing: Ran the release PR successfully 😄 #3782

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner August 22, 2025 15:56
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.02%. Comparing base (7d184bb) to head (39d6990).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3783      +/-   ##
==========================================
- Coverage   87.03%   87.02%   -0.02%     
==========================================
  Files         128      128              
  Lines       16404    16404              
  Branches       62       62              
==========================================
- Hits        14278    14276       -2     
- Misses       1952     1953       +1     
- Partials      174      175       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman
Copy link
Collaborator

Is it possible for this to be used with the renovate workflow as well for when it needs to update additional files?

@ciarams87
Copy link
Contributor Author

Is it possible for this to be used with the renovate workflow as well for when it needs to update additional files?

I don't know - let's try it 😁

@ciarams87 ciarams87 force-pushed the chore/use-github-token-nfr branch from 15e93ae to 970badf Compare August 25, 2025 08:01
@ciarams87 ciarams87 force-pushed the chore/use-github-token-nfr branch from 970badf to 132799c Compare August 26, 2025 16:16
@ciarams87 ciarams87 force-pushed the chore/use-github-token-nfr branch from 132799c to 39d6990 Compare August 26, 2025 20:41
@ciarams87 ciarams87 enabled auto-merge (squash) August 26, 2025 20:42
@ciarams87 ciarams87 merged commit 8449668 into main Aug 27, 2025
65 of 66 checks passed
@ciarams87 ciarams87 deleted the chore/use-github-token-nfr branch August 27, 2025 08:02
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants