KEMBAR78
Update READMEs by sjberman · Pull Request #3788 · nginx/nginx-gateway-fabric · GitHub
Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Aug 25, 2025

Problem: The helm chart README contained a section that is outdated and removed from our official docs. Also, our main README contains some misleading language around supporting a subset of the Gateway API. While we technically do support a subset, the language makes it sound like our intention is to support a subset, which isn't really true and sounds worse than it is.

Solution: Remove the unneeded sections from both READMEs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: The helm chart README contained a section that is outdated and removed from our official docs. Also, our main README contains some misleading language around supporting a subset of the Gateway API. While we technically do support a subset, the language makes it sound like our intention is to support a subset, which isn't really true and sounds worse than it is.

Solution: Remove the unneeded sections from both READMEs.
@sjberman sjberman requested a review from a team as a code owner August 25, 2025 15:28
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Aug 25, 2025
@salonichf5
Copy link
Contributor

why are we removing all information about zero downtime upgrades ( its not outdated? ) - or just trying to specify it in docs ?

@sjberman
Copy link
Collaborator Author

sjberman commented Aug 25, 2025

That process isn't relevant anymore after the control/data plane split. Previously, the data plane would be torn down as part of the control plane upgrade. Now, with readiness probes and the separation, the process is smoother.

@salonichf5
Copy link
Contributor

so will we remove this section from officials docs too ?

That process isn't relevant anymore after the control/data plane split. Previously, the data plane would be torn down as part of the control plane upgrade. Now, with readiness probes and the separation, the process is smoother.

@sjberman
Copy link
Collaborator Author

That doc is different, that's focused on upgrading user apps, not nginx/NGF.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling this

@sjberman sjberman merged commit 2cd485b into nginx:main Aug 25, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 25, 2025
@sjberman sjberman deleted the docs/docs-updates branch August 25, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm-chart Relates to helm chart

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants