KEMBAR78
Run nightly on production runners, ignore .git for vm sync by ciarams87 · Pull Request #4087 · nginx/nginx-gateway-fabric · GitHub
Skip to content

Run nightly on production runners, ignore .git for vm sync #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Run nightly on production runners, ignore .git for vm sync #4087

merged 1 commit into from
Oct 16, 2025

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 16, 2025 •
edited
Loading

Proposed changes

Problem: Nightly run is still failing

Solution: Run nightly on production runners, as they have access to push to the Plus registry

Also simplified the go proxy setup for the assertion job, and removed syncing the .git directory for vm sync

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

@ciarams87 ciarams87 requested a review from a team as a code owner October 16, 2025 16:00
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (7f40f9e) to head (c6e23e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4087      +/-   ##
==========================================
- Coverage   86.71%   86.69%   -0.02%     
==========================================
  Files         128      128              
  Lines       16758    16758              
  Branches       62       62              
==========================================
- Hits        14531    14529       -2     
- Misses       2043     2044       +1     
- Partials      184      185       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 merged commit 7374a97 into main Oct 16, 2025
61 checks passed
@ciarams87 ciarams87 deleted the chore/fix-pipeline-issues branch October 16, 2025 20:37
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjee19 bjee19 bjee19 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees

No one assigned

Labels

chore Pull requests for routine tasks tests Pull requests that update tests

Projects

NGINX Gateway Fabric
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ciarams87 @bjee19 @salonichf5