Chore: fix helm and NFR tests in the pipeline #4096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The cert-generator job was failing with:
because GitHub Actions' actions/download-artifact does not preserve file permissions. When the binary artifacts are uploaded and then downloaded, they lose the execute bit.
The Flow
Solution: Added
--chmod=0755to all COPY commands in build/Dockerfile that copy the gateway binaryThis ensures the binary always has execute permissions in the final image, regardless of the source file permissions.
Also fixed a separate issue that prevented
make build TARGET=containerfrom working (wrong module path) and fixed the conditions for the nightly schedule to use the correct runnerTesting: https://github.com/nginx/nginx-gateway-fabric/actions/runs/18586202163/job/52991407973?pr=4096
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.