KEMBAR78
Fix goreleaser by ciarams87 · Pull Request #4146 · nginx/nginx-gateway-fabric · GitHub
Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: Goreleaser is now trying to upload files that don't exist

Solution: Remove the --output-signature=${signature}" - "--output-certificate=${certificate}" as the new bundle combines these into one

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner October 22, 2025 18:32
@github-actions github-actions bot added the bug Something isn't working label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.50%. Comparing base (89f821d) to head (4ea7a03).
⚠️ Report is 1 commits behind head on release-2.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4146      +/-   ##
===============================================
- Coverage        86.52%   86.50%   -0.02%     
===============================================
  Files              131      131              
  Lines            17796    17796              
  Branches            74       74              
===============================================
- Hits             15398    15395       -3     
- Misses            2198     2201       +3     
  Partials           200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 enabled auto-merge (squash) October 22, 2025 18:43
@ciarams87 ciarams87 disabled auto-merge October 22, 2025 19:03
@ciarams87 ciarams87 merged commit fbe1774 into release-2.2 Oct 22, 2025
59 of 62 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 22, 2025
@ciarams87 ciarams87 deleted the fix/goreleaser branch October 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants