KEMBAR78
Fix FAQ hyperlink typo in readme by Prince-Mendiratta · Pull Request #3148 · nlohmann/json · GitHub
Skip to content

Conversation

Prince-Mendiratta
Copy link
Contributor

@Prince-Mendiratta Prince-Mendiratta commented Nov 17, 2021

Hello! To begin with, thank you very much for this amazing library! While going through the readme, I noticed this small typo and thus, the PR to fix it. Please, have a look. 😄

There was a minor typo in the readme where the hyperlink to the FAQ section was linked to localhost. This PR fixes this issue. No changes in the code itself have been made. As far as I've searched through, this seems to be the only occurrence of this issue in the project.

Signed-off-by: Prince Mendiratta prince.mendi@gmail.com

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling eaa3031 on Prince-Mendiratta:develop into ee1208a on nlohmann:develop.

@nlohmann nlohmann self-assigned this Nov 18, 2021
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.10.5 milestone Nov 18, 2021
@nlohmann nlohmann merged commit 7603046 into nlohmann:develop Nov 18, 2021
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants