KEMBAR78
Add to_json() for std::vector<bool>::reference by falbrechtskirchinger · Pull Request #3534 · nlohmann/json · GitHub
Skip to content

Add to_json() for std::vector<bool>::reference #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

Add to_json() for std::vector<bool>::reference #3534

merged 1 commit into from
Jun 13, 2022

Conversation

@falbrechtskirchinger
Copy link
Contributor

Avoids surprises as seen in #3533.

@coveralls
Copy link

coveralls commented Jun 13, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 475d132 on falbrechtskirchinger:vector-bool-proxy into af34396 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jun 13, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
Copy link
Owner

The code looks good, but Clang-Tidy is complaining.

@falbrechtskirchinger
Copy link
Contributor Author

Changed to static_cast<>(). Should be good now.

nlohmann
nlohmann approved these changes Jun 13, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jun 13, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jun 13, 2022
@nlohmann nlohmann merged commit 9c31d54 into nlohmann:develop Jun 13, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the vector-bool-proxy branch June 13, 2022 11:24
mdrost
mdrost reviewed Aug 1, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes

+1 more reviewer

@mdrost mdrost mdrost left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nlohmann nlohmann

Labels

release item: 🔨 further change

Projects

None yet

Milestone

Release 3.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@falbrechtskirchinger @coveralls @nlohmann @mdrost