KEMBAR78
Add amalgamated json-fwd.hpp to release by nlohmann · Pull Request #3687 · nlohmann/json · GitHub
Skip to content

Add amalgamated json-fwd.hpp to release #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2022
Merged

Add amalgamated json-fwd.hpp to release #3687

merged 2 commits into from
Aug 7, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Aug 7, 2022

This is not done in the release script, but by the Makefile in the repo.

falbrechtskirchinger
falbrechtskirchinger approved these changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 7, 2022
falbrechtskirchinger
falbrechtskirchinger approved these changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann mentioned this pull request Aug 7, 2022
Closed
@github-actions github-actions bot added the S label Aug 7, 2022
@nlohmann nlohmann merged commit e1a3fb7 into develop Aug 7, 2022
@nlohmann nlohmann deleted the release_json_fwd branch August 7, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S

Projects

None yet

Milestone

Release 3.11.2

Development

Successfully merging this pull request may close these issues.

2 participants

@nlohmann @falbrechtskirchinger