- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
          fix: Use keep-alive by default for Connection header.
          #1473
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
        
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | However, will it have any effect on the TCP connection? I think just setting the  Although, I did not test it. | 
    
  dhedey 
      added a commit
        to dhedey/node-fetch
      that referenced
      this pull request
    
      Apr 21, 2023 
    
    
      
  
    
      
    
  
Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at https://nodejs.org/api/http.html#new-agentoptions This fixes node-fetch#1735 and likely replaces node-fetch#1473 The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. node-fetch@af21ae6 node-fetch@7f68577
      
        
      
      
  
    1 task
  
    
  jimmywarting 
      pushed a commit
      that referenced
      this pull request
    
      Jul 25, 2023 
    
    
      
  
    
      
    
  
Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at https://nodejs.org/api/http.html#new-agentoptions This fixes #1735 and likely replaces #1473 The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. af21ae6 7f68577
    
  dhedey 
      added a commit
        to dhedey/node-fetch
      that referenced
      this pull request
    
      Jul 27, 2023 
    
    
      
  
    
      
    
  
Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at https://nodejs.org/api/http.html#new-agentoptions This fixes node-fetch#1735 and likely replaces node-fetch#1473 The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. node-fetch@af21ae6 node-fetch@7f68577 This commit is backported to the v2 branch from node-fetch#1736 against v3.
| I suggest this should be closed, as it has been obsoleted by #1736 👍 | 
    
  jimmywarting 
      pushed a commit
      that referenced
      this pull request
    
      Aug 18, 2023 
    
    
      
  
    
      
    
  
Instead, we rely on the underlying http implementation in Node.js to handle this, as per the documentation at https://nodejs.org/api/http.html#new-agentoptions This fixes #1735 and likely replaces #1473 The original change introducing this provided no clear motivation for the override, and the implementation has since been changed to disable this header when an agent is provided, so I think there is sufficient evidence that removing this is the correct behaviour. af21ae6 7f68577 This commit is backported to the v2 branch from #1736 against v3.
  This was referenced May 20, 2024 
      
  This was referenced Oct 1, 2024 
      
  This was referenced Oct 2, 2024 
      
  This was referenced Oct 5, 2024 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Purpose
Use
keep-aliveby default forConnectionheader.Changes
Replace
closebykeep-alive.Additional information
Chromium and Firefox use
keep-aliveby default forConnectionheader.MDN specifies
closeis the default value for HTTP 1.0. And usually, it'skeep-alivefor HTTP 1.1 (version used by Node.js).