KEMBAR78
Don't let themes change flow port label color by bonanitech · Pull Request #3270 · node-red/node-red · GitHub
Skip to content

Conversation

bonanitech
Copy link
Contributor

@bonanitech bonanitech commented Nov 22, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The selector .red-ui-flow-port-label currently uses $secondary-text-color to define its text color, but that variable usually has its value changed by the themes.

I noticed this issue with the Dracula theme. Here's how it looks when using that variable.

Screen Shot 2021-11-22 at 4 35 04 PM

And here's how it looks with the proposed change.

Screen Shot 2021-11-22 at 4 33 43 PM

This uses the same color value defined for $secondary-text-color in the default vanilla theme.

It's like Nick said on Slack some time ago.

Screen Shot 2021-11-22 at 4 41 24 PM

This PR tries to fix that.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.37% when pulling 49a9376 on bonanitech:node-port-label-color into 3e0f080 on node-red:master.

@knolleary knolleary merged commit a3b8f02 into node-red:master Nov 22, 2021
@bonanitech bonanitech deleted the node-port-label-color branch November 22, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants