Don't let themes change flow port label color #3270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The selector
.red-ui-flow-port-labelcurrently uses$secondary-text-colorto define its text color, but that variable usually has its value changed by the themes.I noticed this issue with the Dracula theme. Here's how it looks when using that variable.
And here's how it looks with the proposed change.
This uses the same color value defined for
$secondary-text-colorin the default vanilla theme.It's like Nick said on Slack some time ago.
This PR tries to fix that.
Checklist
gruntto verify the unit tests pass