KEMBAR78
fix env var access using $parent for groups by HiroyasuNishiyama · Pull Request #3278 · node-red/node-red · GitHub
Skip to content

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

If an environment variable reference is made using $parent in a group, the location of the variable reference in the outer environment may become incorrect.
This is because the $parent reference within the group is not reflected in the outside environment.

This PR tries to fix this problem.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 67.38% when pulling c331da7 on node-red-hitachi:fix-env-var-access into 9439cd0 on node-red:master.

@knolleary knolleary merged commit 30e750d into node-red:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants