KEMBAR78
Allow codeEditor theme to be set even if `codeEditor` is not set in settings.js by Steve-Mcl · Pull Request #3794 · node-red/node-red · GitHub
Skip to content

Conversation

@Steve-Mcl
Copy link
Contributor

fixes #3779

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Allow codeEditor theme to be set even if codeEditor is not set in settings.js

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 68.199% when pulling bc7852c on Steve-Mcl:fix-code-editor-theme-from-theme into 51d8792 on node-red:master.

@Steve-Mcl Steve-Mcl requested a review from knolleary July 21, 2022 14:15
@knolleary knolleary merged commit 17d9c25 into node-red:master Jul 21, 2022
@knolleary
Copy link
Member

Thanks @Steve-Mcl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function Node Editor Bg gone to White (again)

3 participants