Fix switch validation of typeof field #4465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonanitech
suggested changes
Dec 1, 2023
packages/node_modules/@node-red/nodes/core/function/10-switch.html
Outdated
Show resolved
Hide resolved
knolleary
commented
Dec 1, 2023
packages/node_modules/@node-red/nodes/core/function/10-switch.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4464
The typeof check in the switch node doesn't need to validate the configuration as they are hardcoded options. The way the rule stores its configuration was making the validator want to look for an actual json string in the config, whereas it is simply the string
json.