Highlight errors in config node sidebar #4529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonanitech
reviewed
Jan 15, 2024
packages/node_modules/@node-red/editor-client/src/sass/tab-config.scss
Outdated
Show resolved
Hide resolved
…fig.scss Co-authored-by: Mauricio Bonani <bonanitech@gmail.com>
|
Now updated to show the warning triangle, including tooltip with details of the error: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4397
This highlights any config nodes with errors in the config node sidebar.
Relying purely on a coloured border isn't idea but is a quick win. Ideally, we'd have the change/error badges consistent with the main workspace, but they are SVG artefacts and the config node sidebar is pure html. I may come back to refine this, but this moves things forward.
It reuses the CSS for unknown nodes so should be compatible with existing themes.