benchmark: add ipc support to spawn stdio config

thisalihassan · marco-ippolito · commit 030059831556 · 2024-05-03T08:30:30.000+02:00
Enabled inter-process communication (ipc) in the stdio configuration of the spawn function within the benchmark subsystem. This change allows for improved data exchange between parent and benchmarked child processes, addressing limitations in performance testing scenarios. Fixes: #52233 Refs: nodejs/performance#161 PR-URL: #52456 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
diff --git a/benchmark/compare.js b/benchmark/compare.js
@@ -83,7 +83,7 @@ if (showProgress) {
     const spawnArgs = ['-c', cpuCore, cli.optional[job.binary], resolvedPath, ...cli.optional.set];
     child = spawn('taskset', spawnArgs, {
       env: process.env,
-      stdio: ['inherit', 'pipe', 'pipe'],
+      stdio: ['inherit', 'pipe', 'pipe', 'ipc'],
     });
 
     child.stdout.pipe(process.stdout);
diff --git a/benchmark/run.js b/benchmark/run.js
@@ -54,7 +54,7 @@ if (format === 'csv') {
   let child;
   if (cpuCore !== null) {
     child = spawn('taskset', ['-c', cpuCore, 'node', scriptPath, ...args], {
-      stdio: ['inherit', 'pipe', 'pipe'],
+      stdio: ['inherit', 'pipe', 'pipe', 'ipc'],
     });
 
     child.stdout.pipe(process.stdout);
