console: use validateOneOf for colorMode validation

rayark1 · targos · commit 37960a67ae3c · 2024-08-14T08:36:57.000+02:00
refactor the Console constructor to use validateOneOf for validating the colorMode parameter. PR-URL: #54245 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -39,14 +39,14 @@ const {
   codes: {
     ERR_CONSOLE_WRITABLE_STREAM,
     ERR_INCOMPATIBLE_OPTION_PAIR,
-    ERR_INVALID_ARG_VALUE,
   },
   isStackOverflowError,
 } = require('internal/errors');
 const {
   validateArray,
   validateInteger,
   validateObject,
+  validateOneOf,
 } = require('internal/validators');
 const { previewEntries } = internalBinding('util');
 const { Buffer: { isBuffer } } = require('buffer');
@@ -124,8 +124,7 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
     throw new ERR_CONSOLE_WRITABLE_STREAM('stderr');
   }
 
-  if (typeof colorMode !== 'boolean' && colorMode !== 'auto')
-    throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode);
+  validateOneOf(colorMode, 'colorMode', ['auto', true, false]);
 
   if (groupIndentation !== undefined) {
     validateInteger(groupIndentation, 'groupIndentation',
diff --git a/test/parallel/test-console-tty-colors.js b/test/parallel/test-console-tty-colors.js
@@ -67,7 +67,7 @@ check(false, false, false);
         });
       },
       {
-        message: `The argument 'colorMode' is invalid. Received ${received}`,
+        message: `The argument 'colorMode' must be one of: 'auto', true, false. Received ${received}`,
         code: 'ERR_INVALID_ARG_VALUE'
       }
     );
