lib: replace string prototype usage with alternatives

avivkeller · marco-ippolito · commit 64c2c2a7ac2e · 2024-05-03T08:30:30.000+02:00
PR-URL: #52440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/options.js b/lib/internal/options.js
@@ -5,6 +5,10 @@ const {
   getEmbedderOptions: getEmbedderOptionsFromBinding,
 } = internalBinding('options');
 
+const {
+  StringPrototypeSlice,
+} = primordials;
+
 let warnOnAllowUnauthorized = true;
 
 let optionsMap;
@@ -43,8 +47,15 @@ function refreshOptions() {
 
 function getOptionValue(optionName) {
   const options = getCLIOptionsFromBinding();
-  if (optionName.startsWith('--no-')) {
-    const option = options.get('--' + optionName.slice(5));
+  if (
+    optionName.length > 5 &&
+    optionName[0] === '-' &&
+    optionName[1] === '-' &&
+    optionName[2] === 'n' &&
+    optionName[3] === 'o' &&
+    optionName[4] === '-'
+  ) {
+    const option = options.get('--' + StringPrototypeSlice(optionName, 5));
     return option && !option.value;
   }
   return options.get(optionName)?.value;
