Revert "stream: fix cloned webstreams not being unref'd"

mcollina · marco-ippolito · commit 8d20b641a2ff · 2024-05-02T10:56:59.000+02:00
This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/internal/webstreams/transfer.js b/lib/internal/webstreams/transfer.js
@@ -146,8 +146,6 @@ class CrossRealmTransformReadableSource {
         error);
       port.close();
     };
-
-    port.unref();
   }
 
   start(controller) {
@@ -221,7 +219,6 @@ class CrossRealmTransformWritableSink {
       port.close();
     };
 
-    port.unref();
   }
 
   start(controller) {
diff --git a/test/parallel/test-webstreams-clone-unref.js b/test/parallel/test-webstreams-clone-unref.js
diff --git a/test/parallel/test-whatwg-webstreams-transfer.js b/test/parallel/test-whatwg-webstreams-transfer.js
@@ -454,23 +454,12 @@ const theData = 'hello';
       tracker.verify();
     });
 
-    // We create an interval to keep the event loop alive while
-    // we wait for the stream read to complete. The reason this is needed is because there's
-    // otherwise nothing to keep the worker thread event loop alive long enough to actually
-    // complete the read from the stream. Under the covers the ReadableStream uses an
-    // unref'd MessagePort to communicate with the main thread. Because the MessagePort
-    // is unref'd, it's existence would not keep the thread alive on its own. There was previously
-    // a bug where this MessagePort was ref'd which would block the thread and main thread
-    // from terminating at all unless the stream was consumed/closed.
-    const i = setInterval(() => {}, 1000);
-
     parentPort.onmessage = tracker.calls(({ data }) => {
       assert(isReadableStream(data));
       const reader = data.getReader();
       reader.read().then(tracker.calls((result) => {
         assert(!result.done);
         assert(result.value instanceof Uint8Array);
-        clearInterval(i);
       }));
       parentPort.close();
     });
