lib: make sure clear the old timer in http server

theanarkh · marco-ippolito · commit d33fc3678417 · 2024-05-03T08:30:15.000+02:00
PR-URL: #52118 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -506,6 +506,9 @@ function setupConnectionsTracking() {
     this[kConnections] = new ConnectionsList();
   }
 
+  if (this[kConnectionsCheckingInterval]) {
+    clearInterval(this[kConnectionsCheckingInterval]);
+  }
   // This checker is started without checking whether any headersTimeout or requestTimeout is non zero
   // otherwise it would not be started if such timeouts are modified after createServer.
   this[kConnectionsCheckingInterval] =
diff --git a/test/parallel/test-http-server-clear-timer.js b/test/parallel/test-http-server-clear-timer.js
@@ -0,0 +1,24 @@
+'use strict';
+const common = require('../common');
+const http = require('http');
+const assert = require('assert');
+const { kConnectionsCheckingInterval } = require('_http_server');
+
+let i = 0;
+let timer;
+const server = http.createServer();
+server.on('listening', common.mustCall(() => {
+  // If there was a timer, it must be destroyed
+  if (timer) {
+    assert.ok(timer._destroyed);
+  }
+  // Save the last timer
+  timer = server[kConnectionsCheckingInterval];
+  if (++i === 2) {
+    server.close(() => {
+      assert.ok(timer._destroyed);
+    });
+  }
+}, 2));
+server.emit('listening');
+server.emit('listening');
