stream: add trailing commas in stream source files

aduh95 · danielleadams · commit d669f2256726 · 2023-04-05T09:58:23.000-04:00
PR-URL: #46686 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -278,6 +278,7 @@ overrides:
       - ./internal/readme.md
       - ./internal/repl/history.js
       - ./internal/source_map/prepare_stack_trace.js
+      - ./internal/streams/*.js
       - ./internal/structured_clone.js
       - ./internal/test/*.js
       - ./internal/test_runner/**/*.js
diff --git a/lib/internal/streams/buffer_list.js b/lib/internal/streams/buffer_list.js
@@ -175,7 +175,7 @@ module.exports = class BufferList {
       // Only inspect one level.
       depth: 0,
       // It should not recurse.
-      customInspect: false
+      customInspect: false,
     });
   }
 };
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -14,7 +14,7 @@ const {
   kDestroyed,
   isDestroyed,
   isFinished,
-  isServerRequest
+  isServerRequest,
 } = require('internal/streams/utils');
 
 const kDestroy = Symbol('kDestroy');
@@ -334,5 +334,5 @@ module.exports = {
   destroyer,
   destroy,
   undestroy,
-  errorOrDestroy
+  errorOrDestroy,
 };
diff --git a/lib/internal/streams/duplex.js b/lib/internal/streams/duplex.js
@@ -114,8 +114,8 @@ ObjectDefineProperties(Duplex.prototype, {
         this._readableState.destroyed = value;
         this._writableState.destroyed = value;
       }
-    }
-  }
+    },
+  },
 });
 
 let webStreamsAdapters;
diff --git a/lib/internal/streams/duplexify.js b/lib/internal/streams/duplexify.js
@@ -29,7 +29,7 @@ const {
 const { AbortController } = require('internal/abort_controller');
 
 const {
-  FunctionPrototypeCall
+  FunctionPrototypeCall,
 } = primordials;
 
 // This is needed for pre node 17.
@@ -90,7 +90,7 @@ module.exports = function duplexify(body, name) {
         objectMode: true,
         write,
         final,
-        destroy
+        destroy,
       });
     }
 
@@ -126,7 +126,7 @@ module.exports = function duplexify(body, name) {
             }
           });
         },
-        destroy
+        destroy,
       });
     }
 
@@ -142,7 +142,7 @@ module.exports = function duplexify(body, name) {
     return from(Duplexify, body, {
       // TODO (ronag): highWaterMark?
       objectMode: true,
-      writable: false
+      writable: false,
     });
   }
 
@@ -192,7 +192,7 @@ module.exports = function duplexify(body, name) {
     return d = new Duplexify({
       objectMode: true,
       writable: false,
-      read() {}
+      read() {},
     });
   }
 
@@ -236,7 +236,7 @@ function fromAsyncGen(fn) {
     destroy(err, cb) {
       ac.abort();
       cb(err);
-    }
+    },
   };
 }
 
diff --git a/lib/internal/streams/end-of-stream.js b/lib/internal/streams/end-of-stream.js
@@ -9,7 +9,7 @@ const {
 } = require('internal/errors');
 const {
   ERR_INVALID_ARG_TYPE,
-  ERR_STREAM_PREMATURE_CLOSE
+  ERR_STREAM_PREMATURE_CLOSE,
 } = codes;
 const {
   kEmptyObject,
@@ -19,7 +19,7 @@ const {
   validateAbortSignal,
   validateFunction,
   validateObject,
-  validateBoolean
+  validateBoolean,
 } = require('internal/validators');
 
 const { Promise, PromisePrototypeThen } = primordials;
diff --git a/lib/internal/streams/from.js b/lib/internal/streams/from.js
@@ -9,7 +9,7 @@ const { Buffer } = require('buffer');
 
 const {
   ERR_INVALID_ARG_TYPE,
-  ERR_STREAM_NULL_VALUES
+  ERR_STREAM_NULL_VALUES,
 } = require('internal/errors').codes;
 
 function from(Readable, iterable, opts) {
@@ -21,7 +21,7 @@ function from(Readable, iterable, opts) {
       read() {
         this.push(iterable);
         this.push(null);
-      }
+      },
     });
   }
 
diff --git a/lib/internal/streams/lazy_transform.js b/lib/internal/streams/lazy_transform.js
@@ -12,7 +12,7 @@ const {
 const stream = require('stream');
 
 const {
-  getDefaultEncoding
+  getDefaultEncoding,
 } = require('internal/crypto/util');
 
 module.exports = LazyTransform;
@@ -43,7 +43,7 @@ function makeSetter(name) {
       value: val,
       enumerable: true,
       configurable: true,
-      writable: true
+      writable: true,
     });
   };
 }
@@ -54,13 +54,13 @@ ObjectDefineProperties(LazyTransform.prototype, {
     get: makeGetter('_readableState'),
     set: makeSetter('_readableState'),
     configurable: true,
-    enumerable: true
+    enumerable: true,
   },
   _writableState: {
     __proto__: null,
     get: makeGetter('_writableState'),
     set: makeSetter('_writableState'),
     configurable: true,
-    enumerable: true
-  }
+    enumerable: true,
+  },
 });
diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js
@@ -27,7 +27,7 @@ const {
 
 const {
   validateFunction,
-  validateAbortSignal
+  validateAbortSignal,
 } = require('internal/validators');
 
 const {
@@ -60,7 +60,7 @@ function destroyer(stream, reading, writing) {
       finished = true;
       destroyImpl.destroyer(stream, err || new ERR_STREAM_DESTROYED('pipe'));
     },
-    cleanup
+    cleanup,
   };
 }
 
@@ -314,7 +314,7 @@ function pipelineImpl(streams, callback, opts) {
         // composed through `.pipe(stream)`.
 
         const pt = new PassThrough({
-          objectMode: true
+          objectMode: true,
         });
 
         // Handle Promises/A+ spec, `then` could be a getter that throws on
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -32,7 +32,7 @@ const {
   Promise,
   SafeSet,
   SymbolAsyncIterator,
-  Symbol
+  Symbol,
 } = primordials;
 
 module.exports = Readable;
@@ -54,7 +54,7 @@ const BufferList = require('internal/streams/buffer_list');
 const destroyImpl = require('internal/streams/destroy');
 const {
   getHighWaterMark,
-  getDefaultHighWaterMark
+  getDefaultHighWaterMark,
 } = require('internal/streams/state');
 
 const {
@@ -65,7 +65,7 @@ const {
     ERR_OUT_OF_RANGE,
     ERR_STREAM_PUSH_AFTER_EOF,
     ERR_STREAM_UNSHIFT_AFTER_END_EVENT,
-  }
+  },
 } = require('internal/errors');
 const { validateObject } = require('internal/validators');
 
@@ -1166,15 +1166,15 @@ ObjectDefineProperties(Readable.prototype, {
       if (this._readableState) {
         this._readableState.readable = !!val;
       }
-    }
+    },
   },
 
   readableDidRead: {
     __proto__: null,
     enumerable: false,
     get: function() {
       return this._readableState.dataEmitted;
-    }
+    },
   },
 
   readableAborted: {
@@ -1186,23 +1186,23 @@ ObjectDefineProperties(Readable.prototype, {
         (this._readableState.destroyed || this._readableState.errored) &&
         !this._readableState.endEmitted
       );
-    }
+    },
   },
 
   readableHighWaterMark: {
     __proto__: null,
     enumerable: false,
     get: function() {
       return this._readableState.highWaterMark;
-    }
+    },
   },
 
   readableBuffer: {
     __proto__: null,
     enumerable: false,
     get: function() {
       return this._readableState && this._readableState.buffer;
-    }
+    },
   },
 
   readableFlowing: {
@@ -1215,46 +1215,46 @@ ObjectDefineProperties(Readable.prototype, {
       if (this._readableState) {
         this._readableState.flowing = state;
       }
-    }
+    },
   },
 
   readableLength: {
     __proto__: null,
     enumerable: false,
     get() {
       return this._readableState.length;
-    }
+    },
   },
 
   readableObjectMode: {
     __proto__: null,
     enumerable: false,
     get() {
       return this._readableState ? this._readableState.objectMode : false;
-    }
+    },
   },
 
   readableEncoding: {
     __proto__: null,
     enumerable: false,
     get() {
       return this._readableState ? this._readableState.encoding : null;
-    }
+    },
   },
 
   errored: {
     __proto__: null,
     enumerable: false,
     get() {
       return this._readableState ? this._readableState.errored : null;
-    }
+    },
   },
 
   closed: {
     __proto__: null,
     get() {
       return this._readableState ? this._readableState.closed : false;
-    }
+    },
   },
 
   destroyed: {
@@ -1273,15 +1273,15 @@ ObjectDefineProperties(Readable.prototype, {
       // Backward compatibility, the user is explicitly
       // managing destroyed.
       this._readableState.destroyed = value;
-    }
+    },
   },
 
   readableEnded: {
     __proto__: null,
     enumerable: false,
     get() {
       return this._readableState ? this._readableState.endEmitted : false;
-    }
+    },
   },
 
 });
@@ -1292,7 +1292,7 @@ ObjectDefineProperties(ReadableState.prototype, {
     __proto__: null,
     get() {
       return this.pipes.length;
-    }
+    },
   },
 
   // Legacy property for `paused`.
@@ -1303,8 +1303,8 @@ ObjectDefineProperties(ReadableState.prototype, {
     },
     set(value) {
       this[kPaused] = !!value;
-    }
-  }
+    },
+  },
 });
 
 // Exposed for testing purposes only.
@@ -1418,6 +1418,6 @@ Readable.wrap = function(src, options) {
     destroy(err, callback) {
       destroyImpl.destroyer(src, err);
       callback(err);
-    }
+    },
   }).wrap(src);
 };
diff --git a/lib/internal/streams/state.js b/lib/internal/streams/state.js
@@ -32,5 +32,5 @@ function getHighWaterMark(state, options, duplexKey, isDuplex) {
 
 module.exports = {
   getHighWaterMark,
-  getDefaultHighWaterMark
+  getDefaultHighWaterMark,
 };
diff --git a/lib/internal/streams/transform.js b/lib/internal/streams/transform.js
@@ -70,7 +70,7 @@ const {
 
 module.exports = Transform;
 const {
-  ERR_METHOD_NOT_IMPLEMENTED
+  ERR_METHOD_NOT_IMPLEMENTED,
 } = require('internal/errors').codes;
 const Duplex = require('internal/streams/duplex');
 const { getHighWaterMark } = require('internal/streams/state');
@@ -99,7 +99,7 @@ function Transform(options) {
       // a "bug" where we check needDrain before calling _write and not after.
       // Refs: https://github.com/nodejs/node/pull/32887
       // Refs: https://github.com/nodejs/node/pull/35941
-      writableHighWaterMark: options.writableHighWaterMark || 0
+      writableHighWaterMark: options.writableHighWaterMark || 0,
     };
   }
 
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
