stream: add new when constructing ERR_MULTIPLE_CALLBACK

haze · lpinca · marco-ippolito · commit f8209ffe45f0 · 2024-05-03T08:30:15.000+02:00
commit c71e548 changed NodeError from a function to a class, and missed a spot where `ERR_MULTIPLE_CALLBACK` was being instantiated. This commit fixes that by adding the new keyword to that instance. Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #52110 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -876,7 +876,7 @@ function needFinish(state) {
 
 function onFinish(stream, state, err) {
   if ((state[kState] & kPrefinished) !== 0) {
-    errorOrDestroy(stream, err ?? ERR_MULTIPLE_CALLBACK());
+    errorOrDestroy(stream, err ?? new ERR_MULTIPLE_CALLBACK());
     return;
   }
   state.pendingcb--;
diff --git a/test/parallel/test-stream-err-multiple-callback-construction.js b/test/parallel/test-stream-err-multiple-callback-construction.js
@@ -0,0 +1,25 @@
+'use strict';
+const common = require('../common');
+const stream = require('stream');
+const assert = require('assert');
+
+class TestWritable extends stream.Writable {
+  _write(_chunk, _encoding, callback) {
+    callback();
+  }
+
+  _final(callback) {
+    process.nextTick(callback);
+    process.nextTick(callback);
+  }
+}
+
+const writable = new TestWritable();
+
+writable.on('finish', common.mustCall());
+writable.on('error', common.mustCall((error) => {
+  assert.strictEqual(error.message, 'Callback called multiple times');
+}));
+
+writable.write('some data');
+writable.end();
