KEMBAR78
chore: remove stale comment by jsoref · Pull Request #8598 · npm/cli · GitHub
Skip to content

chore: remove stale comment #8598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

chore: remove stale comment #8598

merged 1 commit into from
Sep 26, 2025

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 26, 2025

Remove stale comment

References

This comment was originally written like this:

cli/lib/utils/update-notifier.js

Lines 118 to 123 in 103c8c3

// only update the notification timeout if we actually finished checking
module.exports = async npm => {
const notification = await updateNotifier(npm)
// intentional. do not await this. it's a best-effort update.
updateTimeout(npm)
npm.updateNotification = notification

The code that updates the timeout is no longer anywhere close to this comment:

cli/lib/cli/update-notifier.js

Lines 97 to 100 in 4c616e9

// intentional. do not await this. it's a best-effort update. if this
// fails, it's ok. might be using /dev/null as the cache or something weird
// like that.
writeFile(lastCheckedFile(npm), '').catch(() => {})

@jsoref
chore: remove stale comment
4c616e9 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner September 26, 2025 18:29
@owlstronaut owlstronaut merged commit bb4b739 into npm:latest Sep 26, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2025
Merged
@jsoref jsoref deleted the remove-stale-comment branch September 26, 2025 19:03
@npm-cli-bot npm-cli-bot mentioned this pull request Oct 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owlstronaut owlstronaut owlstronaut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsoref @owlstronaut