KEMBAR78
chore: fix spelling in workspaces by jsoref · Pull Request #8620 · npm/cli · GitHub
Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 1, 2025

Spelling errors hurt usability/readability

References

@jsoref jsoref requested a review from a team as a code owner October 1, 2025 12:55
@jsoref jsoref force-pushed the spelling-workspaces-lib-misc branch from 678cd11 to 6876981 Compare October 1, 2025 17:16
@wraithgar
Copy link
Member

This may need to be two PRs. We use conventional commit messages to indicate what kinds of change are in a PR. chore would be for things that aren't included in the published package, fix would be for things that are. This PR mixes that idea across workspaces. Some of the workspaces have changes in ./lib which would require this to be a fix: commit. This isn't appropriate for the workspaces which are only getting changes to the changelog or test files.

Would it be possible to either make this two PRs, OR two separate commits that isolate the fix changes from the chore ones? None of the other PRs you've made had this problem, they only affected either the root package or one workspace at a time. Unfortunately this one doesn't.

@jsoref
Copy link
Contributor Author

jsoref commented Oct 1, 2025

Not a problem (I had originally drafted ~5 branches/potential PRs for this and then decided to try to save some overhead -- I thought I might be able to get away with it since everything seemed to be in comments, apparently that didn't quite work.)

jsoref and others added 8 commits October 1, 2025 14:19
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Gar <wraithgar@github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref force-pushed the spelling-workspaces-lib-misc branch from 6876981 to 21f8507 Compare October 1, 2025 18:19
This was referenced Oct 1, 2025
@wraithgar wraithgar merged commit 5e0909b into npm:latest Oct 1, 2025
67 of 68 checks passed
@jsoref jsoref deleted the spelling-workspaces-lib-misc branch October 1, 2025 18:26
@github-actions github-actions bot mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants