KEMBAR78
Added Environments API by jer-k · Pull Request #1554 · octokit/octokit.rb · GitHub
Skip to content

Added Environments API #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2023
Merged

Added Environments API #1554

merged 3 commits into from
Apr 3, 2023

Conversation

@jer-k
Copy link
Contributor

@jer-k jer-k commented Mar 21, 2023 •
edited
Loading

Resolves #1552

Behavior

Before the change?

After the change?

  • Environments API is implemented

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@jer-k
Copy link
Contributor Author

jer-k commented Mar 21, 2023

Is there a preference for the VCR files formatting? I was looking at the deployments API tests and those files were a single line of JSON, where as mine are formatted over many lines

@kfcampbell
Copy link
Contributor

I'm not aware of a preference for cassette formatting. I think it's okay to leave as-is.

kfcampbell
kfcampbell approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 1ec0b48 into octokit:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kfcampbell kfcampbell kfcampbell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT]: Environments API

2 participants

@jer-k @kfcampbell