KEMBAR78
Add support for Actions Environment Secret Management by hosom · Pull Request #1607 · octokit/octokit.rb · GitHub
Skip to content

Conversation

hosom
Copy link

@hosom hosom commented Aug 14, 2023

Resolves #1611


Before the change?

  • Endpoints for environment secrets within Actions were not supported.

After the change?

  • All of the actions_secret methods have been mapped to equivalents that support environments.
    • get_actions_environment_public_key
    • list_actions_environment_secrets
    • get_actions_environment_secret
    • create_or_update_actions_environment_secret
    • delete_actions_environment_secret

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No breaking changes here!

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failures appear to be linting related. Once that's addressed and the commented tests are addressed, I can get this merged and released!

@hosom
Copy link
Author

hosom commented Aug 22, 2023

My bad on the commented tests. I forgot to uncomment those when I went to add credentials and record for vcr. I've resolved the tests and linter issues.

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I'll get this merged and released shortly.

@kfcampbell kfcampbell merged commit 73fd936 into octokit:main Aug 23, 2023
@hosom hosom deleted the actions-secrets-environment-support branch August 24, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT]: Support for Environment based Repository Secrets

2 participants