KEMBAR78
Paginate deployments by benoittgt · Pull Request #1649 · octokit/octokit.rb · GitHub
Skip to content

Paginate deployments #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Paginate deployments #1649

merged 1 commit into from
Jan 18, 2024

Conversation

@benoittgt
Copy link
Contributor

Before the change?

  • It was not possible to paginate automatically this two endpoints.

After the change?

  • It is possible to paginate the result for deployments and deployment_statuses.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

I followed https://github.com/octokit/octokit.rb/pull/1032/files and doesn't seems it is required here?

Does this introduce a breaking change?

  • Yes
  • No

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

kfcampbell
kfcampbell approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed https://github.com/octokit/octokit.rb/pull/1032/files and doesn't seems it is required here?

What do you mean by it doesn't seem it's required here?

Thank you!

@benoittgt
Copy link
Contributor Author

benoittgt commented Jan 8, 2024 •
edited
Loading

Sorry, I was speaking about tests.

2 workflows awaiting approval

Do you think you can do it ? @kfcampbell ? Thanks a lot 😊

@kfcampbell kfcampbell merged commit 8e1bab0 into octokit:main Jan 18, 2024
@benoittgt benoittgt deleted the paginate-deployments branch January 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kfcampbell kfcampbell kfcampbell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benoittgt @kfcampbell