👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Hey @casperisfine, this change set looks good. Thanks for doing it! ❤️

Would you mind adding some tests? If not I can do that later. I'll approve either way and thanks again!

Something like:

describe '#validate_owner_and_name!' do
    let(:validator) { described_class.new(owner, name, url) }
    let(:repo) { 'octokit_repo' }

    context 'when owner and name are valid and url is absolute' do
      let(:owner) { 'valid_owner' }
      let(:name) { 'valid_name' }
      let(:url) { 'http://octokit.com' }

      it 'does not raise an error' do
        expect { validator.validate_owner_and_name!(repo) }.not_to raise_error
      end
    end

    context 'when owner contains a slash' do
      let(:owner) { 'invalid/owner' }
      let(:name) { 'valid_name' }
      let(:url) { 'http://octokit.com' }

      it 'raises an invalid repository error' do
        expect { validator.validate_owner_and_name!(repo) }.to raise_error(InvalidRepositoryError)
      end
    end

It's already covered by tests in spec/octokit/repository_spec.rb.

The issue is that the Gemfile.lock contains uri (0.13.0) so even on Ruby head it's not yes using the broken version of URI.

The test will only fail once these changes are released and updated in the Gemfile: ruby/uri#107