Change -Werror handling. #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If building level_zero as a subproject, do not build with warnings as errors, leave it up to the parent project to turn these into errors if desired. * If building level_zero with CMake 3.24 or newer, use CMAKE_COMPILE_WARNING_AS_ERROR instead of explicitly setting -Werror. This permits users to turn it off with `cmake --compile-no-warning-as-error`. In both cases, being able to disable -Werror is useful when a parent project or a user wishes to turn on additional warnings that should not be turned into errors. Signed-off-by: Harald van Dijk <harald.vandijk@codeplay.com>
|
This came up when trying to build DPC++ with additional warnings, in order to see where those would trigger in other parts of DPC++. The build just completely broke because of the |
nrspruit
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake --compile-no-warning-as-error.In both cases, being able to disable -Werror is useful when a parent project or a user wishes to turn on additional warnings that should not be turned into errors.