Update ui_model_menu.py blocking the --multi-user access in backend #7098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the --multi-user mode, the app is blocking the access by disabling the UI components. But with a simple inspect an abuser could enable it and run the action. So we should block the access also in the backend. A simple way is to block it in the event_handlers. Here specifically the abuser can't unload the model by doing a simple inspect!
In the --multi-user mode, the app is blocking the access by disabling the UI components. But with a simple inspect an abuser could enable it and run the action. So we should block the access also in the backend. Here in an abuse scenario the abuser can change the Boolean command-line flags (consider the multi_user checkbox) and then enable the "Apply flags/extensions and restart" button only with a simple web inspect. At the end the app will be restarted in a not multi-user (single user) mode and the abuser now has the full control of the app.
|
Makes sense, I wasn't aware non-interactive elements could be made interactive with the browser tools. Nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the --multi-user mode, the app is blocking the access by disabling the UI components. But with a simple inspect an abuser could enable it and run the action. So we should block the access also in the backend. A simple way is to block it in the event_handlers. Here specifically the abuser can't unload the model by doing a simple inspect in the browser!
Checklist: