KEMBAR78
Switch the otelhttp semconv tests to use metricdatatest by dmathieu · Pull Request #6400 · open-telemetry/opentelemetry-go-contrib · GitHub
Skip to content

Switch the otelhttp semconv tests to use metricdatatest #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2024
Merged

Switch the otelhttp semconv tests to use metricdatatest #6400

merged 7 commits into from
Dec 10, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Dec 4, 2024

This switches the otelhttp semconv tests to use the metricdatatest package rather than a custom struct with a partial metrics implementation.

This is meant to make it easier to start implementing the client and server metrics.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Dec 4, 2024
@dmathieu dmathieu force-pushed the otelhttp-semconv-metricdatatest branch from d864447 to baf05ea Compare December 4, 2024 15:52
@dmathieu dmathieu marked this pull request as ready for review December 4, 2024 15:59
@dmathieu dmathieu requested a review from a team as a code owner December 4, 2024 15:59
@dmathieu
Copy link
Member Author

dmathieu commented Dec 4, 2024

This PR may look big based on its diff size, but it's mostly just moving files into a test subpackage (to avoid adding the SDK as a dependency of otelhttp), and making some private methods public (since we're in an internal package, that has no public impact) so they can be used by the subpackage.

@codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.8%. Comparing base (637e1e5) to head (60a12df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ion/net/http/otelhttp/internal/semconv/httpconv.go 80.0% 3 Missing ⚠️
...entation/net/http/otelhttp/internal/semconv/env.go 85.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6400   +/-   ##
=====================================
  Coverage   67.8%   67.8%           
=====================================
  Files        200     200           
  Lines      16589   16589           
=====================================
  Hits       11254   11254           
  Misses      4993    4993           
  Partials     342     342
Files with missing lines Coverage Δ
...ntation/net/http/otelhttp/internal/semconv/util.go 88.0% <100.0%> (ø)
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 93.8% <100.0%> (ø)
...entation/net/http/otelhttp/internal/semconv/env.go 90.4% <85.7%> (ø)
...ion/net/http/otelhttp/internal/semconv/httpconv.go 83.3% <80.0%> (ø)

pellared
pellared reviewed Dec 5, 2024
View reviewed changes
@dmathieu dmathieu mentioned this pull request Dec 6, 2024
Closed
4 tasks
@dmathieu dmathieu mentioned this pull request Dec 10, 2024
Merged
@dmathieu
Copy link
Member Author

Ping @open-telemetry/go-approvers for review.

@MrAlias MrAlias merged commit 5139bd7 into open-telemetry:main Dec 10, 2024
26 checks passed
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pellared pellared pellared left review comments

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees

No one assigned

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

Go: HTTP Semconv Migration
Status: Done

Milestone

v1.33.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dmathieu @dashpole @pellared @MrAlias