ExtendedAttributes issue with custom LogRecordData impl #7363
Description
Describe the bug
This exception is thrown when a custom implementation of LogRecordData is used, and the extended attributes are enabled. This happens specifically when using disk-buffering, which has a custom LogRecordData implementation for when data is deserialized.
There's no issue if the extended attributes aren't enabled, though it seems like they become automatically enabled if the runtime classpath has the extended types available (for this particular case, I think it happens here), so there doesn't seem to be a way to disable them. In my case, it seems like the incubating library comes as a transitive one via the okhttp instrumentation.
Steps to reproduce
- Add the incubating library to a project.
- Export logs using a custom implementation of LogRecordData, such as the one provided by the disk-buffering lib.
- Try to send a log record.
I've modified OTel Android's demo app to reproduce this issue in this branch.
What did you expect to see?
No issues.
What did you see instead?
This stacktrace:
java.lang.IllegalArgumentException: logRecordData must be ExtendedLogRecordData
at io.opentelemetry.exporter.internal.otlp.IncubatingUtil.getExtendedAttributes(IncubatingUtil.java:121)
at io.opentelemetry.exporter.internal.otlp.IncubatingUtil.sizeExtendedAttributes(IncubatingUtil.java:110)
at io.opentelemetry.exporter.internal.otlp.logs.LogStatelessMarshaler.getBinarySerializedSize(LogStatelessMarshaler.java:103)
at io.opentelemetry.exporter.internal.otlp.logs.LogStatelessMarshaler.getBinarySerializedSize(LogStatelessMarshaler.java:26)
at io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil.sizeRepeatedMessageWithContext(StatelessMarshalerUtil.java:135)
at io.opentelemetry.exporter.internal.otlp.logs.InstrumentationScopeLogsStatelessMarshaler.getBinarySerializedSize(InstrumentationScopeLogsStatelessMarshaler.java:55)
at io.opentelemetry.exporter.internal.otlp.logs.InstrumentationScopeLogsStatelessMarshaler.getBinarySerializedSize(InstrumentationScopeLogsStatelessMarshaler.java:21)
at io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil$RepeatedElementPairSizeCalculator.accept(StatelessMarshalerUtil.java:263)
at java.util.IdentityHashMap.forEach(IdentityHashMap.java:1351)
at io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil.sizeRepeatedMessageWithContext(StatelessMarshalerUtil.java:188)
at io.opentelemetry.exporter.internal.otlp.logs.ResourceLogsStatelessMarshaler.getBinarySerializedSize(ResourceLogsStatelessMarshaler.java:67)
at io.opentelemetry.exporter.internal.otlp.logs.ResourceLogsStatelessMarshaler.getBinarySerializedSize(ResourceLogsStatelessMarshaler.java:28)
at io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil$RepeatedElementPairSizeCalculator.accept(StatelessMarshalerUtil.java:263)
at java.util.IdentityHashMap.forEach(IdentityHashMap.java:1351)
at io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil.sizeRepeatedMessageWithContext(StatelessMarshalerUtil.java:188)
at io.opentelemetry.exporter.internal.otlp.logs.LowAllocationLogsRequestMarshaler.calculateSize(LowAllocationLogsRequestMarshaler.java:84)
at io.opentelemetry.exporter.internal.otlp.logs.LowAllocationLogsRequestMarshaler.initialize(LowAllocationLogsRequestMarshaler.java:57)
at io.opentelemetry.exporter.internal.otlp.logs.LogReusableDataMarshaler.export(LogReusableDataMarshaler.java:46)
at io.opentelemetry.exporter.otlp.http.logs.OtlpHttpLogRecordExporter.export(OtlpHttpLogRecordExporter.java:81)
at io.opentelemetry.contrib.disk.buffering.LogRecordFromDiskExporter$$ExternalSyntheticLambda0.apply(D8$$SyntheticClass:0)
at io.opentelemetry.contrib.disk.buffering.internal.exporter.FromDiskExporterImpl.lambda$exportStoredBatch$0$io-opentelemetry-contrib-disk-buffering-internal-exporter-FromDiskExporterImpl(FromDiskExporterImpl.java:73)
at io.opentelemetry.contrib.disk.buffering.internal.exporter.FromDiskExporterImpl$$ExternalSyntheticLambda0.apply(D8$$SyntheticClass:0)
at io.opentelemetry.contrib.disk.buffering.internal.storage.files.ReadableFile.readAndProcess(ReadableFile.java:101)
at io.opentelemetry.contrib.disk.buffering.internal.storage.Storage.readAndProcess(Storage.java:105)
at io.opentelemetry.contrib.disk.buffering.internal.storage.Storage.readAndProcess(Storage.java:83)
at io.opentelemetry.contrib.disk.buffering.internal.exporter.FromDiskExporterImpl.exportStoredBatch(FromDiskExporterImpl.java:61)
at io.opentelemetry.contrib.disk.buffering.LogRecordFromDiskExporter.exportStoredBatch(LogRecordFromDiskExporter.java:41)
at io.opentelemetry.android.features.diskbuffering.SignalFromDiskExporter.exportBatchOfLogs(SignalFromDiskExporter.kt:69)
at io.opentelemetry.android.features.diskbuffering.SignalFromDiskExporter.exportBatchOfEach(SignalFromDiskExporter.kt:87)
at io.opentelemetry.android.features.diskbuffering.scheduler.DefaultExportScheduler.onRun(DefaultExportScheduler.kt:28)
at io.opentelemetry.android.internal.services.periodicwork.PeriodicRunnable.run(PeriodicRunnable.kt:24)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
at java.lang.Thread.run(Thread.java:1012)
What version and what artifacts are you using?
Artifacts: opentelemetry-sdk, opentelemetry-exporter-otlp, opentelemetry-api-incubator
Version: v1.50.0, v1.50.0-alpha