KEMBAR78
PR 6524 with amendments by jkwatson · Pull Request #6569 · open-telemetry/opentelemetry-java · GitHub
Skip to content

Conversation

@jkwatson
Copy link
Contributor

Replacement for #6524 with amendments to the test and the implementation. @junwense I accidentally pushed unverified commits to your main branch. Please feel free to reset your main branch to remove them.

junwense and others added 14 commits June 14, 2024 18:28
fix map Constructor bug
fix map Constructor bug with tests
fix map Constructor bug with tests
modify tests method name
modify tests method name
Modify CaseInsensitiveMap.getKeyLowerCase method modifiers
Modify CaseInsensitiveMap.TestCases
Add dependency guava-annotations
Modify CaseInsensitiveMap TestCase
Modify CaseInsensitiveMap TestCase
Modify CaseInsensitiveMap TestCase
Modify CaseInsensitiveMap TestCase
@codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (fe8a7f4) to head (c555f14).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6569      +/-   ##
============================================
- Coverage     90.63%   90.61%   -0.03%     
- Complexity     6228     6260      +32     
============================================
  Files           679      689      +10     
  Lines         18661    18704      +43     
  Branches       1842     1844       +2     
============================================
+ Hits          16914    16948      +34     
- Misses         1189     1200      +11     
+ Partials        558      556       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkwatson and @junwense

m.forEach(this::put);
}

private static String getKeyLowerCase(@Nonnull String key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we normally don't include NonNull annotations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. I don't remember either way. Happy to remove if you think we should skip it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jkwatson jkwatson merged commit fbb5ebb into open-telemetry:main Jul 13, 2024
@jkwatson jkwatson deleted the pr_6524 branch July 13, 2024 03:09
@junwense
Copy link
Contributor

Replacement for #6524 with amendments to the test and the implementation. @junwense I accidentally pushed unverified commits to your main branch. Please feel free to reset your main branch to remove them.

It's been a while since I last read it, thank you for editing my test case. It's also my first time contributing code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants