📖 Updated CI-Test description #4275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified description to detail test only considers successes. Co-authored-by: Silas Morgan <victorsmorgan@gmail.com> Co-authored-by: Kemon Bynum <kemonbynum18@gmail.com> Signed-off-by: Jordin <j.a.jones107732@spartans.nsu.edu>
Comment on lines
+144
to
+146
| support other source hosting repositories (i.e., Forges). This check only considers | ||
| and rewards repositories that do run test. Repositories, however, will not be penalized | ||
| if they do not run test before pull requests. |
There was a problem hiding this comment.
I'm not sure this reflects the clarification #3616 was trying to make. I believe the distinction was that tests can pass or fail, and Scorecard only considers tests that succeed/pass, not that there are tests present.
Repositories, however, will not be penalized if they do not run test before pull requests.
Repositories are penalized if they don't run tests, so this addition should be removed.
Also please see the CONTRIBUTING.md for instructions on how to modify this file
https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#updating-docs
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified description to detail test only considers successes.
What kind of change does this PR introduce?
Updated documentation of CI-Test check description to highlight it only considers successes.
What is the current behavior?
Description does not mention that this check only considers successes.
What is the new behavior (if this is a feature change)?**
The description now mentions that the check only considers successes.
Which issue(s) this PR fixes
Fixes #3616
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)