🌱 migrate to golangci-lint v2 #4641
Conversation
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4641 +/- ##
==========================================
+ Coverage 66.80% 68.32% +1.52%
==========================================
Files 230 249 +19
Lines 16602 18929 +2327
==========================================
+ Hits 11091 12934 +1843
- Misses 4808 5133 +325
- Partials 703 862 +159 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
this just treats the problem, but good enough for now Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
force-pushed
the
lint-v2-v2
branch
from
c796624 to
768475d
Compare
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Maintained,Security-Policy,CII-Best-Practices,Branch-Protection,Dangerous-Workflow,CI-Tests,Binary-Artifacts,Packaging,Signed-Releases,Code-Review,License,Token-Permissions,SAST,Vulnerabilities,Dependency-Update-Tool,Pinned-Dependencies,Fuzzing |
3 participants
What kind of change does this PR introduce?
linter update
What is the current behavior?
We use v1 of golangci-lint and dont get any updates.
Fix the current linter violations which can be confusing to contributors (e.g. #4639 (comment))
What is the new behavior (if this is a feature change)?**
We migrate to using v2
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Please review one commit at a time, as I tried to break them up, hopefully makes it easier.
The first commit was made by running
golangci-lint migrateand adding the comments back.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)