-
Notifications
You must be signed in to change notification settings - Fork 578
✨ feat(jsx): support fuzzing in jsx files #4663 #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(jsx): support fuzzing in jsx files #4663 #4664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you said you didn't have Go installed, but a test would be nice here to know the change is detecting it. Do you have a link to a file which should be detected?
Are imports the same in jsx vs js?
|
Also, please see the DCO notes: |
40070cc to
b60f286
Compare
Signed-off-by: David Murdoch <dsmurdoch357@gmail.com>
b60f286 to
de398cd
Compare
This is the file that I would like scorecard to be detecting fuzzing: https://github.com/dsm23/dsm23-next-template/blob/main/src/components/button/fuzz.test.tsx |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4664 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.48%
==========================================
Files 230 249 +19
Lines 16602 18884 +2282
==========================================
+ Hits 11091 12896 +1805
- Misses 4808 5129 +321
- Partials 703 859 +156 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
/scdiff generate Fuzzing |
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Fuzzing supports
.jsand.tsfiles but not.jsxand.tsxfiles.What is the new behavior (if this is a feature change)?**
Adds support for more JavaScript file types.
Which issue(s) this PR fixes
Fixes #4663
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)