KEMBAR78
:sparkles: feat(jsx): support fuzzing in jsx files #4663 by dsm23 · Pull Request #4664 · ossf/scorecard · GitHub
Skip to content

Conversation

dsm23
Copy link
Contributor

@dsm23 dsm23 commented Jun 16, 2025

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Fuzzing supports .js and .ts files but not .jsx and .tsx files.

What is the new behavior (if this is a feature change)?**

Adds support for more JavaScript file types.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4663

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@dsm23 dsm23 requested a review from a team as a code owner June 16, 2025 18:41
@dsm23 dsm23 requested review from raghavkaul and spencerschrock and removed request for a team June 16, 2025 18:41
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you said you didn't have Go installed, but a test would be nice here to know the change is detecting it. Do you have a link to a file which should be detected?

Are imports the same in jsx vs js?

@spencerschrock
Copy link
Member

@dsm23 dsm23 force-pushed the feat/support-fuzzing-in-jsx-files branch 3 times, most recently from 40070cc to b60f286 Compare June 17, 2025 14:14
Signed-off-by: David Murdoch <dsmurdoch357@gmail.com>
@dsm23 dsm23 force-pushed the feat/support-fuzzing-in-jsx-files branch from b60f286 to de398cd Compare June 17, 2025 14:19
@dsm23
Copy link
Contributor Author

dsm23 commented Jun 17, 2025

I know you said you didn't have Go installed, but a test would be nice here to know the change is detecting it. Do you have a link to a file which should be detected?

Are imports the same in jsx vs js?

This is the file that I would like scorecard to be detecting fuzzing: https://github.com/dsm23/dsm23-next-template/blob/main/src/components/button/fuzz.test.tsx

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (353ed60) to head (de398cd).
Report is 184 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4664      +/-   ##
==========================================
+ Coverage   66.80%   68.29%   +1.48%     
==========================================
  Files         230      249      +19     
  Lines       16602    18884    +2282     
==========================================
+ Hits        11091    12896    +1805     
- Misses       4808     5129     +321     
- Partials      703      859     +156     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@spencerschrock spencerschrock merged commit 59ed1b6 into ossf:main Jun 17, 2025
38 checks passed
@spencerschrock
Copy link
Member

/scdiff generate Fuzzing

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature

2 participants