✨ feat: Refactor scorecard serve cmd #4665
Conversation
gcanlin
changed the title
|
Don't have time to look in-depth, but wanted to make one comment:
What features specifically? Go 1.22 made good strides at least for the routing |
|
Sorry. I'm unfamiliar with new features of Go. It seems that |
Signed-off-by: fixedpoint <961750412@qq.com>
gcanlin
requested review from
raghavkaul and
spencerschrock
and removed request for
a team
There was a problem hiding this comment.
At a high level this looks like what we want, an http wrapper around the CLI. You said MCP will be built on top of this API, so is it matching what you need for that?
There are a few things that need changed, which I've left individual comments on. The linter also has some thoughts with this file.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4665 +/- ##
==========================================
+ Coverage 66.80% 67.86% +1.05%
==========================================
Files 230 249 +19
Lines 16602 19069 +2467
==========================================
+ Hits 11091 12941 +1850
- Misses 4808 5268 +460
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
…ions, and remove some local parameters
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
Back from vacation, going through my backlog from before and reopenning PRs that went stale waiting for me. |
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
2 participants
What kind of change does this PR introduce?
feature
What is the current behavior?
The current serve uses Go’s built-in http package, which lacks modern features. And It fails to correctly aggregate the total score, and parameters and details cannot be retrieved properly.
What is the new behavior (if this is a feature change)?**
This PR refactors the serve component by migrating the original CLI-based parameter input to a RESTful API interface. Additionally, I replaced the native net/http logic with the chi router, which is lightweight yet expressive and well-suited for modular HTTP services in Go.
Which issue(s) this PR fixes
Related to #4627