✨ recognize escaped emails in security policy documents #4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
requested review from
justaugustus and
spencerschrock
and removed request for
a team
ralphbean
force-pushed
the
additional-email-formats
branch
from
a8840d5 to
c1b69ce
Compare
Some security policy documents may include an email address partially obfuscated in the form security[at]example.org or, especially in markdown, escaped like security\[at\]example.org. This change updates the regex to recognize those two forms, with the tests expanded to cover those cases as well. Signed-off-by: Ralph Bean <rbean@redhat.com>
ralphbean
force-pushed
the
additional-email-formats
branch
from
c1b69ce to
759786d
Compare
ralphbean
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Security-Policy |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.48%
==========================================
Files 230 249 +19
Lines 16602 18884 +2282
==========================================
+ Hits 11091 12896 +1805
- Misses 4808 5129 +321
- Partials 703 859 +156 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I think this counts as a feature (a micro feature).
Some security policy documents may include an email address partially
obfuscated in the form security[at]example.org or, especially in
markdown, escaped like security\[at\]example.org.
This change updates the regex to recognize those two forms, with the
tests expanded to cover those cases as well.
What is the current behavior?
Only emails of the form security@example.org are recognized.
What is the new behavior (if this is a feature change)?**
Emails of the form security[at]example.org and security[at]example.org are recognized.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
This depends first on #4674 being merged.
Does this PR introduce a user-facing change?