🐛 do not allow unsupported ListReleases to fail a run
#4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
requested review from
justaugustus and
raghavkaul
and removed request for
a team
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
- Coverage 66.80% 66.72% -0.09%
==========================================
Files 230 249 +19
Lines 16602 18884 +2282
==========================================
+ Hits 11091 12600 +1509
- Misses 4808 5452 +644
- Partials 703 832 +129 🚀 New features to boost your workflow:
|
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
JamieMagee
force-pushed
the
jamiemagee/unsupported-list-releases
branch
from
cffbf82 to
ce861e1
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Branch-Protection,Signed-Releases |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This check allows clients which currently do not support
ListReleasesto complete a Scorecard run. Currentlyazuredevopsrepo,localdir, andgitdo not supportListReleases.This is a follow-up from #4533, with PR comments addressed, after I let that PR go stale.
What is the current behavior?
Currently, running
scorecardagainst a client that does not supportListReleasesresults in a non-zero exit code, and an error printed to the console:What is the new behavior (if this is a feature change)?**
Partial results for the checks that partially rely on
ListReleases(Branch-Protection,SBOM) and no results forSigned-Releases.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)