KEMBAR78
:sparkles: add support for hadolint SAST by AdamKorcz · Pull Request #4688 · ossf/scorecard · GitHub
Skip to content

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

feature

What is the current behavior?

Scorecard does not support hadolint SAST.

What is the new behavior (if this is a feature change)?**

Scorecard supports hadolint SAST.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Partially fixes #2318 (comment)

Special notes for your reviewer

Does this PR introduce a user-facing change?

Support Hadolint SAST.

@AdamKorcz AdamKorcz requested a review from a team as a code owner June 28, 2025 19:11
@AdamKorcz AdamKorcz requested review from justaugustus and spencerschrock and removed request for a team June 28, 2025 19:11
@AdamKorcz AdamKorcz temporarily deployed to integration-test June 28, 2025 19:11 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz marked this pull request as draft June 28, 2025 19:12
@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.28%. Comparing base (353ed60) to head (3941af7).
⚠️ Report is 209 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
+ Coverage   66.80%   68.28%   +1.47%     
==========================================
  Files         230      249      +19     
  Lines       16602    18909    +2307     
==========================================
+ Hits        11091    12912    +1821     
- Misses       4808     5135     +327     
- Partials      703      862     +159     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamKorcz AdamKorcz temporarily deployed to integration-test June 30, 2025 11:25 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz marked this pull request as ready for review June 30, 2025 11:29
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the few comments

@github-actions
Copy link

This pull request has been marked stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Jul 22, 2025
Signed-off-by: Adam Korczynski <adam@adalogics.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com>
@github-actions
Copy link

github-actions bot commented Aug 3, 2025

This pull request has been marked stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Aug 3, 2025
@justaugustus justaugustus removed the Stale label Aug 3, 2025
@spencerschrock spencerschrock enabled auto-merge (squash) August 4, 2025 16:14
@spencerschrock spencerschrock changed the title 🌱 add support for hadolint SAST ✨ add support for hadolint SAST Aug 4, 2025
@spencerschrock spencerschrock merged commit 6f3fd2c into ossf:main Aug 4, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add more options for SAST tools

3 participants