🌱 limit webhook payload size to 1024 bytes #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typical payload is under 150 bytes, and isn't expected to increase
without substantial field or bucket renaming:
```
{
"shardLoc":"gs://ossf-scorecard-data2/2025.07.07/020002/",
"numShard":133058,
"commitSha":"bb9c347dff6349d986baab6578a46d68a5524c62"
}
```
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4700 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.49%
==========================================
Files 230 249 +19
Lines 16602 18898 +2296
==========================================
+ Hits 11091 12907 +1816
- Misses 4808 5131 +323
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
justaugustus
temporarily deployed
to
integration-test
GitHub Actions
Inactive
justaugustus
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
infra update
What is the current behavior?
The cron webhook will read any size request.
What is the new behavior (if this is a feature change)?**
The webhook will read a max of 1KiB. A typical payload is under 150 bytes, and isn't expected to increase without substantial field or bucket renaming:
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
I did do a small manual test locally:
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)