KEMBAR78
:seedling: add test cases for author name and email by AdamKorcz · Pull Request #4721 · ossf/scorecard · GitHub
Skip to content

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

bug fix

What is the current behavior?

Scorecard does not test for commit author name and email. This is important to test for to make sure Scorecard correctly reads the array.

What is the new behavior (if this is a feature change)?**

Scorecard tests for commit author name and email.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

no

NONE

Signed-off-by: Adam Korczynski <adam@adalogics.com>
@AdamKorcz AdamKorcz requested a review from a team as a code owner July 24, 2025 11:11
@AdamKorcz AdamKorcz requested review from justaugustus and spencerschrock and removed request for a team July 24, 2025 11:11
@AdamKorcz AdamKorcz temporarily deployed to integration-test July 24, 2025 11:12 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (353ed60) to head (6c3c0fc).
Report is 200 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4721      +/-   ##
==========================================
+ Coverage   66.80%   68.29%   +1.49%     
==========================================
  Files         230      249      +19     
  Lines       16602    18898    +2296     
==========================================
+ Hits        11091    12907    +1816     
- Misses       4808     5131     +323     
- Partials      703      860     +157     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencerschrock spencerschrock changed the title 🐛 add test cases for author name and email 🌱 add test cases for author name and email Jul 24, 2025
@spencerschrock spencerschrock merged commit ddedf1e into ossf:main Jul 24, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants