Support ResidentKeyRequirement #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aseigler Would be nice to have a v3 beta release with that. Do you think that's possible? |
|
I could probably get this into a 3.1 beta |
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 77.41% 77.38% -0.03%
==========================================
Files 87 87
Lines 2404 2406 +2
Branches 402 402
==========================================
+ Hits 1861 1862 +1
- Misses 443 444 +1
Partials 100 100
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aseigler
reviewed
Sep 6, 2022
…catorSelection, mark RequireResidentKey as obsolete and update demo accordingly
|
Works for me, sorry it took so long to sort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#310
I can not think of a good unit test. I think it does not need one, right?