KEMBAR78
Format Tests by iamcarbon · Pull Request #320 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Format Tests #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Sep 6, 2022
Merged

Format Tests #320

merged 20 commits into from
Sep 6, 2022

Conversation

@iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Sep 1, 2022 •
edited
Loading

This PR tidies up the test coverage without changing any coverage.

Most of the changes are just reducing whitespace and fixing indentation levels, so it's recommended to review ignoring whitespace.

https://github.com/passwordless-lib/fido2-net-lib/pull/320/files?diff=split&w=1

Changes:

  • Updates the .NET Test SDK
  • Updates xunit
  • Uses C#11 features to simplify code (Raw Strings, utf8 literals, etc)
  • Enables implicit using to reduce using statements
  • Suppress various warnings to reduce the IDE noise when working on tests
  • Use implicit using scopes & file-scoped namespaces to reduce indentation level
  • Various tidying

@iamcarbon
Copy link
Contributor Author

@abergs @aseigler Ready for review. Aiming to add some additional test coverage after this...

@codecov-commenter
Copy link

Codecov Report

Merging #320 (4c4977c) into master (b6f7642) will decrease coverage by 3.37%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   77.41%   74.04%   -3.38%     
==========================================
  Files          87       87              
  Lines        2404     2400       -4     
  Branches      402      402              
==========================================
- Hits         1861     1777      -84     
- Misses        443      536      +93     
+ Partials      100       87      -13
Impacted Files Coverage Δ
Src/Fido2/Fido2NetLib.cs 91.42% <50.00%> (+4.24%) ⬆️
Src/Fido2.Models/Metadata/RgbPaletteEntry.cs 0.00% <0.00%> (-100.00%) ⬇️
...c/Fido2.Models/Metadata/AlternativeDescriptions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Fido2.Models/Metadata/PatternAccuracyDescriptor.cs 0.00% <0.00%> (-100.00%) ⬇️
...ls/Metadata/DisplayPNGCharacteristicsDescriptor.cs 0.00% <0.00%> (-100.00%) ⬇️
Src/Fido2.Models/Metadata/StatusReport.cs 25.00% <0.00%> (-75.00%) ⬇️
...c/Fido2/Metadata/Fido2MetadataServiceRepository.cs 9.70% <0.00%> (-50.49%) ⬇️
Src/Fido2.Models/Metadata/ExtensionDescriptor.cs 50.00% <0.00%> (-50.00%) ⬇️
...rc/Fido2.Models/Metadata/CodeAccuracyDescriptor.cs 50.00% <0.00%> (-50.00%) ⬇️
...o2.Models/Metadata/VerificationMethodDescriptor.cs 50.00% <0.00%> (-50.00%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aseigler aseigler merged commit 0dd29c7 into passwordless-lib:master Sep 6, 2022
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aseigler aseigler aseigler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamcarbon @codecov-commenter @aseigler