Improve Code Quality #326
Merged
Improve Code Quality #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iamcarbon
commented
Sep 28, 2022
iamcarbon
commented
- Remove TypedStringAbstraction & eliminate reflection use (was only used by AttestationType)
- Update System.IdentityModel.Tokens.Jwt
- Use more shared error messages and update assertions
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 77.80% 78.09% +0.29%
==========================================
Files 88 87 -1
Lines 2428 2433 +5
Branches 401 401
==========================================
+ Hits 1889 1900 +11
+ Misses 438 431 -7
- Partials 101 102 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abergs
reviewed
Sep 28, 2022
There was a problem hiding this comment.
@iamcarbon Can you elaborate on the benefits of remving typedString?
abergs
approved these changes
Sep 28, 2022
|
@iamcarbon Good work. Will rebase & merge but would love to hear the reasoning of typedstring removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.