Use file scoped namespaces #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider reviewing while ignoring whitespace. https://github.com/passwordless-lib/fido2-net-lib/pull/343/files?diff=split&w=1 |
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 88 88
Lines 2495 2495
Branches 415 415
=======================================
Hits 1943 1943
Misses 439 439
Partials 113 113
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abergs
approved these changes
Nov 24, 2022
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the remaining files to use file-scoped namespaces. There are no functional changes in this PR.