KEMBAR78
Improve Code Quality by iamcarbon · Pull Request #405 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Improve Code Quality #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 28, 2023
Merged

Improve Code Quality #405

merged 10 commits into from
Jul 28, 2023

Conversation

@iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented Jul 4, 2023 •
edited
Loading

  • Make RgbPaletteEntry a readonly struct
  • Makes UafVersion a readonly struct
  • Makes AuthenticationDevicePublicKeyOutputs immutable
  • Makes PublicKeyCredentialDescriptor immutable
  • Fixes a misspelled class name

@iamcarbon
Copy link
Contributor Author

@abergs @aseigler Ready for feedback / review.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (53caf81) to head (d22e731).
Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
Src/Fido2.Models/Metadata/RgbPaletteEntry.cs 50.00% 7 Missing ⚠️
Src/Fido2.Models/Metadata/UafVersion.cs 45.45% 6 Missing ⚠️
...o2.Models/Objects/PublicKeyCredentialDescriptor.cs 77.77% 2 Missing ⚠️
.../AuthenticationExtensionsDevicePublicKeyOutputs.cs 83.33% 1 Missing ⚠️
...desiredMetadataStatusFido2VerificationException.cs 50.00% 1 Missing ⚠️
Src/Fido2/AuthenticatorAttestationResponse.cs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   74.61%   74.88%   +0.26%     
==========================================
  Files          92       92              
  Lines        2714     2731      +17     
  Branches      453      456       +3     
==========================================
+ Hits         2025     2045      +20     
+ Misses        575      573       -2     
+ Partials      114      113       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon
Copy link
Contributor Author

@abergs Ping. Let me know if you have any feedback.

@abergs
Copy link
Collaborator

abergs commented Jul 21, 2023

@iamcarbon Will merge #379 before this one.

@abergs abergs merged commit 2ef5ff3 into passwordless-lib:master Jul 28, 2023
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abergs abergs abergs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamcarbon @codecov-commenter @abergs