KEMBAR78
Prefer Ed25519 when available by abergs · Pull Request #413 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Conversation

@abergs
Copy link
Collaborator

@abergs abergs commented Jul 31, 2023

Because ED25519 is one of the top recommended public-key algorithms today.

@abergs abergs requested a review from aseigler July 31, 2023 14:16
@abergs abergs added the enhancement Enhancements or general improvements label Jul 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #413 (94bde6e) into master (02772cc) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files          95       95           
  Lines        2739     2739           
  Branches      456      456           
=======================================
  Hits         2050     2050           
  Misses        576      576           
  Partials      113      113           
Files Changed Coverage Δ
Src/Fido2.Models/CredentialCreateOptions.cs 41.86% <0.00%> (ø)

@abergs abergs merged commit 906c238 into master Aug 10, 2023
@abergs abergs deleted the ed25519 branch August 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements or general improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants