Review lifecycle of services registered in the DI container #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 74.11% 74.16% +0.05%
==========================================
Files 100 100
Lines 2712 2710 -2
Branches 443 443
==========================================
Hits 2010 2010
+ Misses 598 596 -2
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
I would need to think about what side effect this change could have before this is merged. I welcome others analysis on this... |
|
@iamcarbon Happy to hear if you have any thoughts |
|
Looks good. 👍 |
abergs
approved these changes
Jan 26, 2024
|
Thank you @joegoldman2 👍 Happy friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #439.