KEMBAR78
Rename `origChallenge` parameter in `Fido2.MakeNewCredentialAsync` by joegoldman2 · Pull Request #460 · passwordless-lib/fido2-net-lib · GitHub
Skip to content

Conversation

@joegoldman2
Copy link
Contributor

Fixes #441.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebfd75d) 73.83% compared to head (4394df4) 73.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          99       99           
  Lines        2710     2710           
  Branches      445      445           
=======================================
  Hits         2001     2001           
  Misses        604      604           
  Partials      105      105           
Files Coverage Δ
Src/Fido2/Fido2.cs 90.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@abergs abergs merged commit 85b5149 into passwordless-lib:master Nov 17, 2023
@joegoldman2 joegoldman2 deleted the fix/441 branch November 17, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename origChallenge parameter in Fido2.MakeNewCredentialAsync

3 participants